Make docs environment deterministic#41926
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Documentation preview: https://vllm--41926.org.readthedocs.build/en/41926/ |
mergify
Bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modernizes the documentation build pipeline by transitioning to uv for dependency management, adding a pre-commit hook for compiling requirements, and simplifying the ReadTheDocs configuration. However, two critical issues were identified: the specified Python platform in the pre-commit configuration targets a glibc version incompatible with the ReadTheDocs environment, and the autogenerated requirements/docs.txt contains invalid, future-dated package versions that will cause installation failures.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
I've reverted the uv stuff because it causes readthedocs to try and use |
github-actions
Bot
added
the
ready
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Libin Tang <libin.tang@intel.com>
2 participants
Docs builds have started timing out during the
mkdocs buildstage. Since we only have 4 docs builders available, this effectively reduces the number of builders available to other docs builds.This PR:
pip-compilefor docs dependencies so that they are all pinnedThis likely won't fix the timeouts, but implementing these best practises will make debugging easier.